New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3116: [Plasma] Add "ls" to object store #2470
Conversation
This is now ready to give feedback or merge (I marked it as experimental so it can be evolved). |
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
=========================================
Coverage ? 87.47%
=========================================
Files ? 246
Lines ? 43412
Branches ? 0
=========================================
Hits ? 37975
Misses ? 5437
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
x, _, _ = create_object(plasma_client, 3, metadata_size=0, seal=False) | ||
t2 = time.time() | ||
l6 = plasma_client.list() | ||
assert math.floor(t1) <= l6[x]["create_time"] <= math.ceil(t2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some chance this could be flaky due to non-monotonic clocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd say let's keep this clock for now, since it needs to be consistent with the timestamp from the store, where it makes more sense to use the system time than a monotonic clock. If it turns out to be flaky, we can find a different solution.
This adds plasma_client.list to the plasma client API.
It can be used like so: